-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
@gergelytakacs error() and serialPrint() functions sometimes throw a warning message: "ISO C++ forbids converting a string constant to 'char*'" when used like they were meant to - serialPrint("text"). Sketch is compilable even without this change, this is just to satisfy the compiler by using the "more correct" argument type.
- Loading branch information
1 parent
8e0d12b
commit fec9bea
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fec9bea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All righty, nice find. Please make a search for
error()
in the entire library (other shields as well), since this could potentially affect the API for other shields. Although I don't expect much use oferror()
so far (which is a shame). Maybe you could also put a note in #42 to teach others how to use these functions correctly.