Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View Hierarchy positioning is relative #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timfish
Copy link

@timfish timfish commented Jan 19, 2025

It was not mentioned in the RFC but View Hierarchy positioning is expected to be relative to the parent window.

In Sentry, flutter projects were hard-coded to use absolute positioning but it was not possible to override this for other platforms.

I opened a PR to allow overriding this by including absolute in the rendering_system:

@timfish
Copy link
Author

timfish commented Jan 20, 2025

Another alternative might be to add a top level positioning property which can be relative or absolute and defaults to relative if not set?

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants