ci: Faster and smarter backup/restore tests #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3516 +/- ##
==========================================
+ Coverage 93.23% 99.45% +6.21%
==========================================
Files 3 3
Lines 207 184 -23
==========================================
- Hits 193 183 -10
+ Misses 14 1 -13 ☔ View full report in Codecov by Sentry. |
BYK
added a commit
that referenced
this pull request
Jan 10, 2025
This is an initial transitionary patch before landing #3516. Once we land this, we will point https://github.com/getsentry/action-self-hosted-e2e-tests/blob/main/action.yml to this repo, land #3516, then update users of the old action to use this one and remove that repo.
BYK
added a commit
that referenced
this pull request
Jan 10, 2025
This is an initial transitionary patch before landing #3516. Once we land this, we will update users of the old action to use this one and remove that repo. Then land #3516 safely. Great thing is, with this patch and the subsequent update to getsentry/action-self-hosted-e2e-tests to use this one, all the repos would be using the Docker Volume caching we introduced in #3488.
|
@hubertdeng123 okay, this looks pretty good but waiting on getsentry/relay#4442 and getsentry/snuba#6746 before merging (otherwise those repos will be broken) After those, I'll merge this and will also retire https://github.com/getsentry/action-self-hosted-e2e-tests/blob/main/action.yml |
hubertdeng123
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
to