-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Duplicati #1179
Conversation
Another excellent submission @sharknoon! Let's get gallery assets finalized. In the meantime, here's a couple things to think about that I would love your thoughts on:
EDIT: (for point 2 below) After some discussion, we've decided we cannot blindly bind mount
volumes:
- ${APP_DATA_DIR}/data:/data
- ${UMBREL_ROOT}/data/storage:/umbrel-storage
- ${UMBREL_ROOT}/app-data:/umbrel-app-data |
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
@sharknoon, gallery assets are live: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/duplicati Let's take another look at the password behaviour and then launch this! |
Thank you for your reply @nmfretz :) I have looked around in the documentation and found out, that I only have to set the UI password once: Maybe we could use a hook to run after the install and set the password by running the container and if the user changes it in the UI, the change would persist. But I don't know if the hook would rerun after an update. But I think this will add a lot of complexity just for being able to change the password. I would recommend against that. @nmfretz What is your opinion? |
Thanks for looking into that @sharknoon. I agree with your recommendation to keep things simple here. Let's launch Duplicati as-is, and if we get significant feedback on this then we can use lifecycle hooks to change the behaviour. Going live 🎉 |
App Submission
App name
Duplicati
256x256 SVG icon
Gallery images
I have tested my app on: