Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Duplicati #1179

Merged
merged 5 commits into from
Jul 31, 2024
Merged

App Submission: Duplicati #1179

merged 5 commits into from
Jul 31, 2024

Conversation

sharknoon
Copy link
Contributor

App Submission

App name

Duplicati

256x256 SVG icon

logo

Gallery images

Bildschirmfoto am 2024-06-27 um 23 11 58
Screenshot 2024-06-27 230700
Bildschirmfoto am 2024-06-27 um 23 11 18
Bildschirmfoto am 2024-06-27 um 23 11 23

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

@nmfretz
Copy link
Contributor

nmfretz commented Jul 9, 2024

Another excellent submission @sharknoon! Let's get gallery assets finalized.

In the meantime, here's a couple things to think about that I would love your thoughts on:

  1. Password
    It looks like the web UI let's us change the password, which obviously won't persist on app restart because we set it via the entrypoint (which I think we are required to do in order to even have a password and set things up remote access from different hostnames, is that correct?). I'll look into whether there is something we can change this, but I think we are probably stuck with this behaviour.

EDIT: (for point 2 below) After some discussion, we've decided we cannot blindly bind mount app-data at this stage in umbrelOS' development, because it breaks the data sandboxing we have in place today. We have some ideas on user customized data access settings that will be coming to umbrelOS. Once this is in place, we can add app-data. Users would be able to change access settings such that they allow Duplicati to only access specific apps to back up.

  1. Adding app-data directory
    RIght now we bind ${UMBREL_ROOT}/data/storage:/umbrel so that users can choose to back up directories and files within /home/home/umbrel/data/storage. This allows users to backup things like media, books, anything they store in that directory, etc. I'm imagining a lot of users would also want to back up app specific data (e.g., nextcloud, nostr relay database, app config files, etc). In order to do this they need access to /home/home/umbrel/app-data.
    so users can backup data from specific apps (e.g., nextcloud, or maybe their qbittorrent config, etc). I'm currently thinking on the implications, but if we want to do this then we could change the bind mounts to something like:
volumes:
      - ${APP_DATA_DIR}/data:/data
      - ${UMBREL_ROOT}/data/storage:/umbrel-storage
      - ${UMBREL_ROOT}/app-data:/umbrel-app-data

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

@nmfretz
Copy link
Contributor

nmfretz commented Jul 30, 2024

@sharknoon, gallery assets are live: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/duplicati

Let's take another look at the password behaviour and then launch this!

image

@sharknoon
Copy link
Contributor Author

Thank you for your reply @nmfretz :)

I have looked around in the documentation and found out, that I only have to set the UI password once: This option is saved so you do not need to set it on each run. Setting an empty value disables the password..

Maybe we could use a hook to run after the install and set the password by running the container and if the user changes it in the UI, the change would persist. But I don't know if the hook would rerun after an update.

But I think this will add a lot of complexity just for being able to change the password. I would recommend against that.

@nmfretz What is your opinion?

@nmfretz
Copy link
Contributor

nmfretz commented Jul 31, 2024

Thanks for looking into that @sharknoon. I agree with your recommendation to keep things simple here. Let's launch Duplicati as-is, and if we get significant feedback on this then we can use lifecycle hooks to change the behaviour.

Going live 🎉

@nmfretz nmfretz merged commit 36fa2a6 into getumbrel:master Jul 31, 2024
1 check passed
@sharknoon sharknoon deleted the duplicati branch September 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants