Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a dead ReDoS link in docs #14705

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix a dead ReDoS link in docs #14705

merged 1 commit into from
Nov 7, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Nov 7, 2023

Fix a dead link related to the ReDoS query in all places where it occurs.

  • old link: http://www.cs.bham.ac.uk/~hxt/research/reg-exp-sec.pdf (claimed to be "James Kirrage, Asiri Rathnayake, Hayo Thielecke: Static Analysis for Regular Expression Denial-of-Service Attacks. NSS 2013.", now "404: Not Found")
  • new link: https://arxiv.org/abs/1301.0849 ("Static Analysis for Regular Expression Denial-of-Service Attacks James Kirrage, Asiri Rathnayake, Hayo Thielecke")
  • I noticed this was a dead link while working on the Swift ReDoS query .qhelp, and already did the substitution there. This PR extends that substitution to every other occurrence.

@geoffw0 geoffw0 added JS documentation Java Python ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. Ruby labels Nov 7, 2023
@geoffw0 geoffw0 requested review from a team as code owners November 7, 2023 09:32
Copy link
Contributor

github-actions bot commented Nov 7, 2023

QHelp previews:

@geoffw0 geoffw0 added the no-change-note-required This PR does not need a change note label Nov 7, 2023
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@geoffw0
Copy link
Contributor Author

geoffw0 commented Nov 7, 2023

If there are no objections I'm going to merge this at the end of my day today whether or not it's been approved by all teams. There are several approvals already and I don't think it's a particularly controversial change.

@geoffw0
Copy link
Contributor Author

geoffw0 commented Nov 7, 2023

Merging...

@geoffw0 geoffw0 merged commit b632947 into github:main Nov 7, 2023
26 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Java JS no-change-note-required This PR does not need a change note Python ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants