fix: add missing nop logic for custom properties plugin #738
+169
−123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734
Implements proper
nop
(dry-run) logic handling for Custom PropertIes plugin, aligning with documentation and other plugins.Changes
paginate
for gettings all custom propertiesgithub.request
/repos/:org/:repo/properties/values
to/repos/{owner}/{repo}/properties/values
for consistency with GitHub APImodifyProperty
methodNote
Currently, organization properties are not fetched from the GH Organization API. When modifying repo custom properties, this results in a 422 error if the property isn't defined at the org level. Future improvements could: