Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loads promo.json from an s3 bucket #3921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Jan 13, 2025

Description

Used env var GL_PROMO_URI as a reference to a public s3 bucket

Screen.Recording.2025-01-13.at.13.13.01.mov

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev requested review from eamodio, d13 and axosoft-ramint and removed request for eamodio, d13 and axosoft-ramint January 13, 2025 06:20
@nzaytsev nzaytsev force-pushed the features/21-read-promos-from-s3-bucket branch from c98e43f to 0817063 Compare January 13, 2025 06:38
@nzaytsev nzaytsev force-pushed the features/21-read-promos-from-s3-bucket branch from 0817063 to 216de15 Compare January 13, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant