Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieves pull request for a branch in Azure DevOps to show in Home #3999

Merged
merged 0 commits into from
Feb 3, 2025

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jan 30, 2025

(#3977)

Description

✅ you can see associated issues and prs on Home

A PR on Home:

Enriched autolinks of PRs and issues on Home:

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One comment but can address post-merge.

Comment on lines 104 to 123
return new PullRequest(
provider,
{
id: pr.createdBy.id,
name: pr.createdBy.displayName,
avatarUrl: pr.createdBy.imageUrl,
url: pr.createdBy.url,
},
pr.pullRequestId.toString(),
pr.pullRequestId.toString(),
pr.title,
getPullRequestUrl(options.baseUrl, owner, projectName, repoName, pr.pullRequestId),
{
owner: owner,
repo: repo,
},
azurePullRequestStatusToState(pr.status),
new Date(pr.creationDate),
new Date(pr.creationDate),
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the near future it would be nice to abstract this part into a fromAzurePullRequest similar to our fromGitHubPullRequest function.

@sergeibbb sergeibbb force-pushed the 3977-azure-autolinks branch from 7e383a0 to fabd51c Compare January 31, 2025 14:12
@sergeibbb sergeibbb force-pushed the 3977-azure-home-issue-support branch from 5fd960f to c40c391 Compare January 31, 2025 18:10
@axosoft-ramint axosoft-ramint force-pushed the 3977-azure-home-issue-support branch from c40c391 to a0a5820 Compare February 3, 2025 23:00
@axosoft-ramint axosoft-ramint merged commit a0a5820 into 3977-azure-autolinks Feb 3, 2025
@axosoft-ramint axosoft-ramint deleted the 3977-azure-home-issue-support branch February 3, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure DevOps Integration Support - Add Home PR/Issue Support
2 participants