-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieves pull request for a branch in Azure DevOps to show in Home #3999
Retrieves pull request for a branch in Azure DevOps to show in Home #3999
Conversation
4f099c4
to
5fd960f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One comment but can address post-merge.
return new PullRequest( | ||
provider, | ||
{ | ||
id: pr.createdBy.id, | ||
name: pr.createdBy.displayName, | ||
avatarUrl: pr.createdBy.imageUrl, | ||
url: pr.createdBy.url, | ||
}, | ||
pr.pullRequestId.toString(), | ||
pr.pullRequestId.toString(), | ||
pr.title, | ||
getPullRequestUrl(options.baseUrl, owner, projectName, repoName, pr.pullRequestId), | ||
{ | ||
owner: owner, | ||
repo: repo, | ||
}, | ||
azurePullRequestStatusToState(pr.status), | ||
new Date(pr.creationDate), | ||
new Date(pr.creationDate), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the near future it would be nice to abstract this part into a fromAzurePullRequest
similar to our fromGitHubPullRequest
function.
7e383a0
to
fabd51c
Compare
5fd960f
to
c40c391
Compare
c40c391
to
a0a5820
Compare
fabd51c
to
16b4307
Compare
(#3977)
Description
✅ you can see associated issues and prs on Home
A PR on Home:
![](https://private-user-images.githubusercontent.com/83944326/408233422-7f07c441-da9f-4785-a720-78c0ec9d8c4b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDk3MjEsIm5iZiI6MTczODkwOTQyMSwicGF0aCI6Ii84Mzk0NDMyNi80MDgyMzM0MjItN2YwN2M0NDEtZGE5Zi00Nzg1LWE3MjAtNzhjMGVjOWQ4YzRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MjM0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4M2IxOWJlMGQwMWU2ZmJmNDU2NWI5ZTczNGM1NzhmYzA5NDU4MThjNDYxODMyNjcxNjQwMDcyNWI4OGNiMTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.edlgSXr4C-LI59gQeMl3_ZanMCeEjs9DnzXF2DY0bgg)
Enriched autolinks of PRs and issues on Home:
![](https://private-user-images.githubusercontent.com/83944326/408234086-db6592ef-b5c3-4621-91e6-3f4a0c551250.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDk3MjEsIm5iZiI6MTczODkwOTQyMSwicGF0aCI6Ii84Mzk0NDMyNi80MDgyMzQwODYtZGI2NTkyZWYtYjVjMy00NjIxLTkxZTYtM2Y0YTBjNTUxMjUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MjM0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MTEyYzYyZTIxOWFiODBjMmVkZjY5MzhmMjQ1MTk3Y2JkNGU1MTEzODNmNDYyYzY5M2NiNDc1NWE0Y2NmNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.11K8wJxBu3SvSFHKFbAGm79aSTxbgqcEoLt3L_uEpi8)
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses