Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huggingface support and action added #7

Merged
merged 18 commits into from
Aug 29, 2024
Merged

Huggingface support and action added #7

merged 18 commits into from
Aug 29, 2024

Conversation

John-Peters-UW
Copy link
Collaborator

No description provided.

@John-Peters-UW
Copy link
Collaborator Author

Action failure is fine, see: https://github.com/gitter-lab/metl-pretrained/actions/runs/10478100258

I moved the ref to main so when we merge this, it will run on pushes/pr to main, however that breaks it for this PR

Copy link
Member

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many comments on this, it looks good already for the most part.

It would also help to have a couple sentence readme in the huggingface subdirectory explaining what this is all doing at a high level.

huggingface/combine_files.py Show resolved Hide resolved
huggingface/requirements.txt Show resolved Hide resolved
@samgelman samgelman merged commit f6ceac5 into main Aug 29, 2024
8 of 13 checks passed
@agitter agitter deleted the huggingface_support branch August 30, 2024 22:12
@agitter
Copy link
Member

agitter commented Aug 30, 2024

I pushed a small cleanup commit in ec84935 directly to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants