-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Glitch] Update client-side media resizing resolution to 3840x2160 to match model #2304
base: main
Are you sure you want to change the base?
Conversation
The whole thing at the time was completely rushed and my comments were ignored but to be fair this was before Claire was hired. It should have never been set at 3840x2160 or you're still compressing Pictures that are 2:3 or 4:3 right down with the current imagemagick. Instead it needs to be changed to 3840x2560 to compensate for Aspect Ratio. This has worked for months on my instance. app/models/media_attachment.rb also needs an adjust at Line 45 to change it overall. |
This PR is about client-side resizing of media before upload; the server side unconditionally processes local media with Imagemagick to strip metadata, the size limit or aspect ratio are not relevant to that. |
This is a one-line fix to bring glitch-soc in sync with Mastodon. Why hasn't it been merged yet? |
I did make a patch that also helps out on both glitch and Vanilla mastodon for it all but I was never sure how to explain it otherwise. Heres the glitch one.
|
Both mainline mastodon and the backend of glitch have increased the image size limit to 3840x2160.
Client-side resizing has been overlooked, causing images uploaded via the glitch flavour to be resized, when uploading via the vanilla flavour wouldn't resize the same images.