Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlarge the gc workers to 10 #21462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wy65701436
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if you have only 5 workers in your system, but the users select 10?

  • Maybe this option should be configurable in config or even UI.
  • allow the user to specify the worker amount in % up to 55 e.g. fibonacci
    1 | 2 | 3 | 5 | 8 | 13 | 21 | 34 | 55
  • Also from the UX/UI design perspective, a dropdown for >5

Dropdown: Use when the options are limited (e.g., up to 5-7) and users can quickly scan and select from predefined values.
Example: Choosing between 1, 2, 3.

In your case: Switch from dropdown to an input field with validation for numbers between 1 and 10

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants