-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement debug.List #9163
base: master
Are you sure you want to change the base?
Implement debug.List #9163
Conversation
Thanks, can you push the "sign CLA button" above? |
I’ve completed the CLA Signing, but for some reason the bot thinks I have not. |
You have probably a email mismatch between the mail address you used for the commit (as in: your Git user) and the email address registered on GitHub. You can fix this by adding email aliases in your GitHub profile. |
…ter or keys of the map.
2994a16
to
8df11bd
Compare
Thanks for pointing it out, looks like CLA check passes now! |
In case I need to add tests, please let me know. I looked around and could not find anything specific to add tests to apart from the init.go file, which I'm unclear on how to structure the example. |
We need some basic tests. Just create a |
@bep I just added some basic tests, please have a look! Thanks. |
I just noticed that the functions also returns fields that are not exported, let me fix that. |
f2ff596
to
5d2f2b7
Compare
Fixed the issue, please review. |
Thanks for this. I need to think a little before pulling this into the main branch. I have tested this a little, and while it does work great on technical level, I fear it may expose too much (deprecated and internal methods (not meant to be used in the templates, e.g. |
Refers #9148
This PR implements
debug.List
method that uses reflect package to to list exported fields and methods names on structs/pointers and all keys in a map.