-
Notifications
You must be signed in to change notification settings - Fork 52
feat add windows compilation support #54
base: dev
Are you sure you want to change the base?
Conversation
error C2397: conversion from 'unsigned __int64' to 'CK_ULONG' requires a narrow ing conversion
add vcpkg install gtest:x64-windows
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot signed ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR – adding Windows support sounds good.
The general approach seems reasonable, but on a quick first pass through the changes there's a few small details that would be good to get tidied up before merging.
remove static path to p11 library
fix move FILEPATH_NATIVE definition from pkcs11-env.h to pkcs11test.cc
windows.h and stdlib.h
GTest::gtest_main GTest::gmock GTest::gmock_main
Let me know about your feedback on those changes.
Best,
Arnaud