Skip to content

Commit

Permalink
Revert "Reduce the chunk size for writing tracevalues and postings en…
Browse files Browse the repository at this point in the history
…tries during ingestions"

This reverts commit c06913b.

Reason for revert: The timeout was caused due to parent context which has now been fixed. This change should no longer be necessary.

Original change's description:
> Reduce the chunk size for writing tracevalues and postings entries during ingestions
>
> - These determine the number of rows written in a single INSERT statement during ingestion.
> - Seeing timeouts occuring in the spanner instances for these statements, so trying to reduce the chunk size to see if it helps.
>
> Change-Id: I5fafb1870ac79050375aabcfaf57e83ff1088d4f
> Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/932582
> Reviewed-by: Farid (Mojtaba) Faridzad <faridzad@google.com>
> Commit-Queue: Ashwin Verleker <ashwinpv@google.com>

Change-Id: I4e05305efe9127c907da69f3b85949d5823d7450
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/932636
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ashwin Verleker <ashwinpv@google.com>
  • Loading branch information
Ashwin Verleker authored and SkCQ committed Dec 24, 2024
1 parent b433dbc commit b0b99f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions perf/go/tracestore/sqltracestore/sqltracestore.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ const (
// data. Note that values over 200 caused the insert rate to drop precipitously,
// going from 20,000 qps with a batch size of 100 down to 400 qps with a batch
// size of 200.
writeTracesValuesChunkSize = 500
writeTracesPostingsChunkSize = 500
writeTracesValuesChunkSize = 1000
writeTracesPostingsChunkSize = 1000
writeTracesParamSetsChunkSize = 100

// See writeTracesChunkSize.
Expand Down

0 comments on commit b0b99f2

Please sign in to comment.