Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AzureAD oauth for application registrations #2152

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add AzureAD oauth for application registrations #2152

wants to merge 13 commits into from
+212 −12

Conversation

callumau
Copy link

@callumau callumau commented Nov 25, 2024 •
edited
Loading

PR Description

Adding the existing prometheus application registration for oauth on Azure

Which issue(s) this PR fixes

Fixes #2150

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@callumau callumau marked this pull request as ready for review November 26, 2024 10:35
@callumau callumau requested review from clayton-cornell and a team as code owners November 26, 2024 10:35
@mattdurham mattdurham self-assigned this Nov 26, 2024
@callumau
Copy link
Author

Still requires better validation

alloy/internal/component/prometheus/remotewrite/types.go

Line 327 in ba66b2a

// Validate OAuth if it is provided

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell left review comments

@mattdurham mattdurham mattdurham left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mattdurham mattdurham

Labels
needs-attention type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Prometheus remote write AzureAD oauth
4 participants
@callumau @CLAassistant @mattdurham @clayton-cornell