Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable fixes, toolkit migration and docs website update #729

Merged
merged 9 commits into from
Jan 15, 2024
Merged

variable fixes, toolkit migration and docs website update #729

merged 9 commits into from
Jan 15, 2024

Conversation

yesoreyeram
Copy link
Collaborator

  • Updated the grafana plugin SDK from v0.193.0 to v0.197.0
  • Added support for variables in the backend parser root selector ( previously interpolation was not handled for rootSelector property )
  • Fixed a bug where variable values were not passed with the nested variable queries ( passed scopedVars to metricFindQuery method )
  • Better support for variable handling when variable queries have more than 1 column ( Addes support for __text and __value kind of variable support similar to mysql/postgres

@yesoreyeram yesoreyeram marked this pull request as ready for review December 28, 2023 11:00
@yesoreyeram yesoreyeram requested a review from a team as a code owner December 28, 2023 11:00
gabor
gabor approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yesoreyeram yesoreyeram changed the title Variable fixes variable fixes, toolkit migration and docs website update Jan 15, 2024
@yesoreyeram yesoreyeram merged commit 3b3ce7d into main Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

@gwdawson gwdawson Awaiting requested review from gwdawson gwdawson is a code owner automatically assigned from grafana/oss-big-tent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesoreyeram @gabor