Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest auth lib update #743

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Digest auth lib update #743

merged 4 commits into from
Jan 19, 2024

Conversation

yesoreyeram
Copy link
Collaborator

@yesoreyeram yesoreyeram commented Jan 17, 2024

This PR updates the digest auth library from archived library github.com/xinsnake/go-http-digest-auth-client to github.com/icholy/digest

Also updates the plugin SDK to latest

@yesoreyeram yesoreyeram requested a review from a team as a code owner January 17, 2024 11:37
@gabor
Copy link
Contributor

gabor commented Jan 17, 2024

do you think it would make sense to later move https://github.com/yesoreyeram/go-http-digest-auth-client to github/grafana ?

Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yesoreyeram
Copy link
Collaborator Author

Thanks Gabor for the feedback. Ended with another library which is relatively well maintained and popular.

@yesoreyeram yesoreyeram merged commit 7524758 into main Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants