Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to example authentication and lint according to Grafana Labs' style #749

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 30, 2024

Style is defined in https://grafana.com/docs/writers-toolkit/.

Happy to answer any questions regarding the style changes.

Broken links were reported in https://grafana.slack.com/archives/CNCRV74GP/p1706429377929869.

…s style

Style is defined in https://grafana.com/docs/writers-toolkit/.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested a review from a team as a code owner January 30, 2024 12:48
Copy link
Collaborator

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @jdbaldry for the PR.

Co-authored-by: Sriram <153843+yesoreyeram@users.noreply.github.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
Copy link
Member Author

CI failures look unrelated but also not a flake unfortunately.

@yesoreyeram yesoreyeram merged commit 65ea35a into main Jan 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants