Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tbot): K8S Role creation is optional #51500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximumG
Copy link

@maximumG maximumG commented Jan 27, 2025

Description

Closing #51181.

K8S Role & RoleBinding are created by default but their creation does not depend on the ServiceAccount creation anymore.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2025

CLA assistant check
All committers have signed the CLA.

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Fixes gravitational#51181.

K8S `Role` & `RoleBinding` are created by default. Their creation does not depends on the `ServiceAccount` creation anymore.
@maximumG maximumG force-pushed the fix-tbot-roles-creation branch from 4c187af to 236c0c8 Compare January 27, 2025 15:52
@maximumG
Copy link
Author

recheck

Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your high quality contribution!

Could you rename serviceAccountRole.create into rbac.create for consistency with the teleport-cluster chart values?

Also please note that this is a breaking change (although very small), I don't think this will be backportable to previous v15, v16 or v17 versions.

cc @strideynet

@hugoShaka hugoShaka requested a review from strideynet January 29, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants