Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install corepack@0.31.0 instead of hardcoding integrity keys #51819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravicious
Copy link
Member

@ravicious ravicious commented Feb 4, 2025

Closes #51796.
Ent PR: https://github.com/gravitational/teleport.e/pull/6008

In #51761, I initially just hardcoded the keys used by corepack to avoid updating the tooling. The whole situation seemed a bit fishy to me and the solution of "Just update corepack to the newest version" seemed to me on par with "Just ignore integrity checks", in that in the heat of the moment it'd be the simplest change to make which would unblock the rest of the team but also potentially introduce a malicious code to the project.

The dust has settled a bit since yesterday and following Fred's advice, I'm replacing the hardcoded keys with an updated version of corepack which has those updated keys baked in. Initially I thought we'd be able to remove the env var with keys when we'll get around to updating our Node.js version. But this might take some time and there's no guarantees that the new Node.js version used by Electron is going to actually have corepack >= 0.31.0.

We should still get rid of npm install -g corepack@0.31.0 once we update Node.js to a version that comes with corepack >= 0.31.0, this has been reflected in build.assets/versions.mk.

I made a successful tag build with this PR and the ent PR. https://github.com/gravitational/teleport.e/actions/runs/13133912317

@ravicious ravicious added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 backport/branch/v17 labels Feb 4, 2025
@ravicious ravicious marked this pull request as ready for review February 4, 2025 14:18
@codingllama
Copy link
Contributor

This is certainly nicer, thanks @ravicious!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds fail due to corepack Cannot find matching keyid
4 participants