Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deep-source.yml #169

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update deep-source.yml #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab3c11
Update deep-source.yml
guibranco Jan 27, 2025
ae978c1
Merge branch 'main' into guibranco-patch-2
gstraccini[bot] Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/deep-source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- main
pull_request:
types: [opened, synchronize, reopened]
Comment on lines 6 to 8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider documenting the security implications of removing pull_request_target

This change restricts the workflow to only run on internal PRs, which improves security but changes how external contributions are handled. It would be helpful to document this decision in the workflow file or repository documentation.

Suggested change
- main
pull_request:
types: [opened, synchronize, reopened]
- main
# Security Note: This workflow intentionally only runs on internal pull requests.
# We removed pull_request_target to prevent potential security risks from external contributions
# running in the context of our repository. External contributors will need to fork the repo
# and have their PRs reviewed before these checks run.
# For more information see: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
pull_request:
types: [opened, synchronize, reopened]

pull_request_target:
types: [opened, synchronize, reopened]

jobs:
DeepSource:
Expand All @@ -31,9 +29,6 @@ jobs:
(
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name == github.repository
) || (
github.event_name == 'pull_request_target' &&
github.event.pull_request.head.repo.full_name != github.repository
) || (
github.event_name == 'workflow_dispatch'
)
Expand Down
Loading