Dequalify names when constructing RVars in rfactor #8560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC complains about certain warning flags being passed to C sources. This will break -Werror builds. The flags in question are: * -Woverloaded-virtual * -Wsuggest-override * -Wno-old-style-cast
In pybind/pybind11#4772, the py::exception<>::operator() functions were deprecated because the static destructor could run after interpreter finalization and lead to undefined behavior. The old code has been modified to use PyErr_SetString directly, which also avoids lifetime issues.
abadams
reviewed
Jan 29, 2025
| for (const auto &[var, min, extent] : intermediate_rdom.domain()) { | ||
| for (size_t i = 0; i < intermediate_rdom.domain().size(); i++) { | ||
| const auto &var = intermediate_rdims[i].var; | ||
| const auto &[_, min, extent] = intermediate_rdom.domain()[i]; |
There was a problem hiding this comment.
The underscore here... Is that not the var name? Could this just be:
const auto &[var, min, extent] = intermediate_rdom.domain()[i];
Or is the name not dequalified yet or something
There was a problem hiding this comment.
The rdims list contains the old name while the rdom has the new (dequalified) names. The expressions in the predicates will refer to the old names.
abadams
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a very frustrating bug that arises from treating a Dim name as a valid RVar name. In this particular case, everything appears to work until we serialize the schedule in an autoscheduler. Managing renaming mars some of the elegance of the new rfactor implementation, which I find sad. I think a "perfect" solution would lift naming restrictions rather than lean into them.
Adding Rename splits is not a solution for the reasons documented in #8557.
Includes two drive-by fixes for compiler warnings I noticed while building.
Fixes #8557