Show errors when NPM install fails #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample output now:
I don't think we should fail when npm fails, but it would be nice to let the user know there was a problem. This could happen if there's some issue with their npm install, or if they don't have it installed at all.
Open to adding more text, or making this smaller (if it's a long error message, the whole thing will show). For example, we could just show the last line
npm ERR! /Users/sean/.npm/_logs/2023-11-07T01_38_25_312Z-debug-0.log
if we want to.(The underlying issue here was fixed in #119, but I reintroduced it locally to get the failure)