Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run bundle check || bundle install after hanami install #128

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Run bundle check || bundle install after hanami install #128

merged 2 commits into from
Nov 7, 2023

Conversation

cllns
Copy link
Member

@cllns cllns commented Nov 7, 2023

To ensure any new Gemfile entries are installed

@cllns cllns requested a review from timriley November 7, 2023 03:50
@cllns cllns force-pushed the bundle-install-after-hanami-install branch 2 times, most recently from 4c588ba to 193ce31 Compare November 7, 2023 04:07
@cllns
Run bundle check || bundle install after hanami install
3c555c3 
To ensure any new Gemfile entries are installed
@cllns cllns force-pushed the bundle-install-after-hanami-install branch from 193ce31 to 3c555c3 Compare November 7, 2023 04:23
@timriley timriley requested a review from jodosha November 7, 2023 09:36
timriley
timriley approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really glad you spotted this, @cllns! Fix looks good to me.

@jodosha — I think this would be good to get in before 2.1.0 stable, but I don't mind when. If this has to wait until after rc2, I'm comfortable with that.

Let us know if/when you think this might be good to merge.

@timriley timriley added this to the v2.1.0 milestone Nov 7, 2023
jodosha
jodosha approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@jodosha jodosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cllns Thanks for spotting and fixing this. It adds a new level of solidity to the installation. 🙏

@jodosha jodosha merged commit 5df5d30 into main Nov 7, 2023
@jodosha jodosha deleted the bundle-install-after-hanami-install branch November 7, 2023 10:33
@jodosha jodosha self-assigned this Nov 7, 2023
@jodosha jodosha added the fix label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timriley timriley timriley approved these changes

@jodosha jodosha jodosha approved these changes

Assignees

@jodosha jodosha

Labels
fix
Projects
Hanami 2.1
Status: Done
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cllns @timriley @jodosha