Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use owner template #10304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use owner template #10304

wants to merge 1 commit into from

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Feb 5, 2025

Description:

  • use owner jdbc template for node data migration

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added the bug Type: Something isn't working label Feb 5, 2025
@jnels124 jnels124 added this to the 0.124.0 milestone Feb 5, 2025
@jnels124 jnels124 requested a review from a team as a code owner February 5, 2025 01:14
Signed-off-by: Jesse Nelson <jesse@hashgraph.com>
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (8bb4bb3) to head (69c5486).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10304   +/-   ##
=========================================
  Coverage     92.18%   92.19%           
- Complexity     8005     8006    +1     
=========================================
  Files           980      980           
  Lines         33445    33444    -1     
  Branches       4218     4218           
=========================================
+ Hits          30832    30834    +2     
+ Misses         1612     1610    -2     
+ Partials       1001     1000    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run spotlessApply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants