Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effective tag binding include relation to projects and workspaces #1043

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

sebasslash
Copy link
Contributor

Description

Allow the user to include EffectiveTagBindings when listing projects or workspaces. Adds the relation to each respective model.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

@sebasslash sebasslash requested a review from a team as a code owner January 23, 2025 21:15
@sebasslash sebasslash force-pushed the sebasslash/allow-effective-tag-binding-include branch from 7497254 to 24260f8 Compare January 23, 2025 21:18
@sebasslash sebasslash force-pushed the sebasslash/allow-effective-tag-binding-include branch from 24260f8 to 7190298 Compare January 24, 2025 16:23
@datadog-terraform-cloud-hashicorp

Datadog Report

Branch report: sebasslash/allow-effective-tag-binding-include
Commit report: 4b8eb78
Test service: hashicorp/go-tfe

✅ 0 Failed, 1421 Passed, 164 Skipped, 19m 24.85s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@Maed223 Maed223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sebasslash sebasslash merged commit 876de2d into main Jan 24, 2025
7 checks passed
@sebasslash sebasslash deleted the sebasslash/allow-effective-tag-binding-include branch January 24, 2025 18:37
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants