Add an ignore annotation #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a struct could never contain a public field that could be ignored by the JSONAPI marshalling/unmarshalling. This made it difficult to provide a struct that only serialized part of the fields. Additionally the JSON (and BSON) marshallers support the '-' as an ignore annotation. This commit adds the "-" annotation and adds tests and docs updates for this new annotation type.
|
Hrmmm although, I just noticed, that if don't annotate it all, it's ignored...not sure this PR is needed :-( |
|
Yeah, I think omitting the annotation altogether is probably the right move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a struct could never contain a public field that could be ignored by the JSONAPI marshalling/unmarshalling. This made it difficult to provide a struct that only serialized part of the fields. Additionally the JSON (and BSON) marshallers support the '-' as an ignore annotation.
This commit adds the "-" annotation and adds tests and docs updates for this new annotation type.