Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3077: Make actorType and origin a required entity provenance #6272

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

It should always be possible to specify these

🚫 Blocked by

We need to migrate the production database first:

🔍 What does this change?

  • Make the provenance fields required in the graph
  • Adjust TS to always pass the fields
  • Remove redundant types we previously used to enforce it because the graph is now properly exposing these types.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@TimDiekmann TimDiekmann requested a review from CiaranMn January 28, 2025 10:19
@TimDiekmann TimDiekmann self-assigned this Jan 28, 2025
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/blocks Relates to first-party blocks (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/tests New or updated tests area/apps labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 21.21%. Comparing base (827a1a4) to head (357e035).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...hash-api/src/graph/ontology/primitive/data-type.ts 0.00% 6 Missing ⚠️
...-api/src/graph/ontology/primitive/property-type.ts 0.00% 5 Missing ⚠️
...sh-api/src/graph/ontology/primitive/entity-type.ts 0.00% 3 Missing ⚠️
...-activities/infer-metadata-from-document-action.ts 0.00% 1 Missing ⚠️
...ctivities/flow-activities/persist-flow-activity.ts 0.00% 1 Missing ⚠️
...vities/flow-activities/research-entities-action.ts 0.00% 1 Missing ⚠️
...earch-entities-action/shared/deduplicate-claims.ts 0.00% 1 Missing ⚠️
...w-activities/shared/create-file-entity-from-url.ts 0.00% 1 Missing ⚠️
...s-from-text/infer-entity-claims-from-text-agent.ts 0.00% 1 Missing ⚠️
...es-from-claims/propose-entity-from-claims-agent.ts 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6272      +/-   ##
==========================================
- Coverage   21.21%   21.21%   -0.01%     
==========================================
  Files         573      573              
  Lines       19658    19659       +1     
  Branches     2870     2870              
==========================================
  Hits         4171     4171              
- Misses      15435    15436       +1     
  Partials       52       52              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.39% <0.00%> (-0.01%) ⬇️
apps.hash-api 1.14% <0.00%> (ø)
local.hash-backend-utils 8.81% <0.00%> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.91% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TimDiekmann and others added 4 commits January 28, 2025 11:55
Co-authored-by: Ciaran Morinan <37743469+CiaranMn@users.noreply.github.com>
…].page/create-entity-page/create-initial-draft-entity-subgraph.ts

Co-authored-by: Ciaran Morinan <37743469+CiaranMn@users.noreply.github.com>
…].page/entity-editor/links-section/outgoing-links-section/cells/linked-with-cell/linked-entity-list-editor.tsx

Co-authored-by: Ciaran Morinan <37743469+CiaranMn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/blocks Relates to first-party blocks (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests New or updated tests type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

2 participants