Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema validator templates #13

Merged
merged 10 commits into from
Dec 21, 2023
Merged

Update schema validator templates #13

merged 10 commits into from
Dec 21, 2023

Conversation

lugehorsam
Copy link
Contributor

@lugehorsam lugehorsam commented Dec 13, 2023

  • Added schemas for stats, incentives and progressions.

  • Minor updates to energy and event leaderboards.

  • Also added more examples to the definitions folder.

  • Need to verify that this is the correct JSON field name "-" and if so I'll add it to the unlockables schema
    e3c4eb7#diff-bccc16b359e387cd48e76123fe40c0d20cdef0996615ddebd9fe31717a195ef7R30

  • Need to verify what properties should be marked as required for incentives. I made all of them required for now but couldn't really grok what should or shouldn't be from looking at the incentives code @zyro

@lugehorsam lugehorsam requested review from zyro and tomglenn December 13, 2023 17:29
@lugehorsam
Copy link
Contributor Author

"-" is computed so we won't add.

I narrowed down incentives required fields after discussion with andrei.

@lugehorsam lugehorsam merged commit d7b50b0 into main Dec 21, 2023
1 check passed
@lugehorsam lugehorsam deleted the luke/schema-updates branch December 21, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant