Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing energy reward field #73

Closed
wants to merge 1 commit into from
Closed

Add missing energy reward field #73

wants to merge 1 commit into from

Conversation

Calm0
Copy link
Collaborator

@Calm0 Calm0 commented Nov 28, 2024

Used if a reward is defined when spending an energy

Used if a reward is defined when spending an energy
@Calm0 Calm0 requested a review from novabyte November 28, 2024 21:44
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024

CLA assistant check
All committers have signed the CLA.

@Calm0 Calm0 requested a review from zyro November 28, 2024 21:45
@zyro
Copy link
Member

zyro commented Nov 29, 2024

@Calm0 this should be covered by the available_rewards field, shouldn't it? https://github.com/heroiclabs/hiro/pull/73/files#diff-f80cd1900cdad452f1365c009b40be6eccdc69f4756b4d1cf2d2ae49654fd547R1661

@Calm0
Copy link
Collaborator Author

Calm0 commented Nov 29, 2024

@zyro Initially I had the idea of wanting the rolled reward to be part of the Energy so it can be accessed from anywhere as the "last rolled reward" but now I don't think that it makes much sense to keep a record of that especially that the reward will only be rolled when the client requests that by spending it so the EnergySpendReward response should be enough at the spot to do whatever with it.
Closing this 👍

@Calm0 Calm0 closed this Nov 29, 2024
@Calm0 Calm0 deleted the nabil-energy-reward branch November 29, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants