-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: categories & tags tests. #35
base: master
Are you sure you want to change the base?
Conversation
TooBug
commented
Nov 24, 2021
•
edited
Loading
edited
- Fix categories and tags front matter .
- Fix nested lists. (4 spaces or tab, not 2 spaces.)
- Fix dl.(One dl tag with multi dt&dd tags are not rendered as intended.)
Markdown supports 2 spaces indent. Just add extra 4 spaces and tab tests, leave 2 spaces ones as they are. |
@SukkaW Not really. Some packages allows 2 spaces, but not So the html is not correct if using 2 spaces, makes the tests no meaning, Because this beyond the responsibility of a theme, it's a renderer-issue. |
categories and tags front matter is working, even without indentation https://hexo-optimize.pages.dev/all/2013/12/24/categories/ |
TOC in Need to fix it somehow. |
To have a line break without a paragraph, you will need to use two trailing spaces. | ||
Note that this line is separate, but within the same paragraph. | ||
(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.) | ||
To have a line break without a paragraph, you will need to use two trailing spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces in this line should not be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking.
- Foo | ||
- Bar | ||
- Baz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not necessary.
* Unordered sub-list. | ||
1. Actual numbers don't matter, just that it's a number | ||
1. Ordered sub-list | ||
1. Ordered sub-list | ||
4. And another item. | ||
|
||
You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown). | ||
You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown). | ||
|
||
To have a line break without a paragraph, you will need to use two trailing spaces. | ||
Note that this line is separate, but within the same paragraph. | ||
(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.) | ||
To have a line break without a paragraph, you will need to use two trailing spaces. | ||
Note that this line is separate, but within the same paragraph. | ||
(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.