Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: categories & tags tests. #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

TooBug
Copy link

@TooBug TooBug commented Nov 24, 2021

  1. Fix categories and tags front matter .
  2. Fix nested lists. (4 spaces or tab, not 2 spaces.)
  3. Fix dl.(One dl tag with multi dt&dd tags are not rendered as intended.)

@SukkaW
Copy link
Member

SukkaW commented Nov 24, 2021

  • Fix nested lists. (4 spaces or tab, not 2 spaces.)

Markdown supports 2 spaces indent. Just add extra 4 spaces and tab tests, leave 2 spaces ones as they are.

@TooBug
Copy link
Author

TooBug commented Nov 25, 2021

@SukkaW Not really. Some packages allows 2 spaces, but not marked, which Hexo uses.

So the html is not correct if using 2 spaces, makes the tests no meaning, Because this beyond the responsibility of a theme, it's a renderer-issue.

@stevenjoezhang
Copy link
Member

categories and tags front matter is working, even without indentation

https://hexo-optimize.pages.dev/all/2013/12/24/categories/
https://hexo-optimize.pages.dev/all/2013/12/24/tags/

@stevenjoezhang
Copy link
Member

TOC in markdown.md is also broken, because of hexojs/hexo#2137

Need to fix it somehow.

To have a line break without a paragraph, you will need to use two trailing spaces.
Note that this line is separate, but within the same paragraph.
(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)
To have a line break without a paragraph, you will need to use two trailing spaces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces in this line should not be removed.

Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking.

Comment on lines +4 to +6
- Foo
- Bar
- Baz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not necessary.

Comment on lines +76 to +85
* Unordered sub-list.
1. Actual numbers don't matter, just that it's a number
1. Ordered sub-list
1. Ordered sub-list
4. And another item.

You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).
You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).

To have a line break without a paragraph, you will need to use two trailing spaces.
Note that this line is separate, but within the same paragraph.
(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)
To have a line break without a paragraph, you will need to use two trailing spaces.
Note that this line is separate, but within the same paragraph.
(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants