Skip to content

Commit

Permalink
Merge pull request #339 from Enforcer/review-chapter-19
Browse files Browse the repository at this point in the history
Review of chapter 19
  • Loading branch information
hjwp authored Jan 29, 2025
2 parents c8c59cd + 5c7f484 commit c6491e3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion chapter_19_spiking_custom_auth.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Oauth? Openid? "Login with Facebook"? Ugh.
For me those all have unacceptable creepy overtones;
why should Google or Facebook know what sites you're logging into and when?

// SEBASTIAN: As much as I appreciate the history of the chapter, I am not sure if they bring any value to the reader
In the first edition I used an experimental project called "Persona",
cooked up by a some of the wonderful techno-hippy-idealists at Mozilla,
but sadly that project was abandoned.
Expand Down Expand Up @@ -906,7 +907,7 @@ and reintroduce them one by one in a test-driven way.
==== Reverting Our Spiked Code



// SEBASTIAN: Oh, this is neat! Remove all the spike code and leave the test behind

[subs="specialcharacters,quotes"]
----
Expand Down

0 comments on commit c6491e3

Please sign in to comment.