Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect issue feedback #25

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix redirect issue feedback #25

merged 3 commits into from
Dec 7, 2023

Conversation

svara
Copy link
Collaborator

@svara svara commented Dec 7, 2023 •
edited
Loading

  • Wrap the dynamically resolved location in a computed var.
  • Update logging to reflect the correct location.
  • Add tests.

@svara svara requested a review from joemasilotti December 7, 2023 09:45
@svara svara mentioned this pull request Dec 7, 2023
Merged
joemasilotti
joemasilotti approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@joemasilotti joemasilotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the computed property, too.

@joemasilotti joemasilotti marked this pull request as ready for review December 7, 2023 16:41
@joemasilotti joemasilotti merged commit beec8c3 into fix-redirect-issue Dec 7, 2023
1 check failed
@joemasilotti joemasilotti deleted the fix-redirect-issue-feedback branch December 7, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemasilotti joemasilotti joemasilotti approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svara @joemasilotti