Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gobot update eventer #1124

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

jasonyunicorn
Copy link

@jasonyunicorn jasonyunicorn commented Jan 14, 2025

This PR is a continuation of #980, which appears to have been abandoned.

Solved issues and/or description of the change

The following is a translation from the original PR:

Hello, I encountered some issues during project development and hope to make the following adjustments:
• Allow customizing the channel length of the eventer.
• Allow defining the number of goroutines consuming the out channel to implement a multi-consumer model.
• When a callback function triggers a panic, output the error through a crash event.

Please review the code and check if the modifications are appropriate.

...

Manual test

  • OS and Version (Win/Mac/Linux):
  • Adaptor(s) and/or driver(s):
    ...

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added the name to the corresponding README.md
  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

If this is a Go version update:

  • go.mod to new version updated
  • modules updated (go get -u -t ./...)
  • CI files updated
  • linter setting and linter version (if a newer one exist) updated
  • linter issues fixed or suppressed by config

If this is a PR for release:

  • The PR's target branch is 'hybridgroup:release'
  • I have adjusted the CHANGELOG.md (or already prepared and will be merged as soon as possible)

wangzhen-jg and others added 6 commits July 8, 2023 18:17
@jasonyunicorn jasonyunicorn changed the base branch from release to dev January 14, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants