-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html-to-slate-ast): add htmlToSlateASTSync function #115
Conversation
|
How about adding a |
I tried to make it work like this, but no luck. When using |
I'll export everything from the root as there are no errors on the server for polyfilling jsdom functions now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @jpedroschmitz 👏
Do you think we should document the problem with the existing bundler and how migrating to tsup
solved it? Perhaps it could be useful for internal docs 🙂
Sounds great. I'll document this internally and create a ticket so we can move away from tsdx completely. @anmolarora1 |
It adds
htmlToSlateASTSync
, which doesn't depend on jsdom and will work exclusively on the browser environment.