test(plugin-htlc-coordinator-besu): use Jest error assert in refund.test #3730
+16
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbatuto
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
jagpreetsinghsasan
requested changes
Jan 28, 2025
...htlc-coordinator-besu/src/test/typescript/integration/plugin-htlc-coordinator/refund.test.ts
Show resolved
Hide resolved
adrianbatuto
force-pushed
the
adrianbatuto/issue3457
branch
from
426cf6e to
0b74687
Compare
jagpreetsinghsasan
approved these changes
Jan 30, 2025
petermetz
approved these changes
Feb 6, 2025
Primary Changes ---------------- 1. Refactored try-catch scenario in refund.test.ts Fixes hyperledger-cacti#3457 Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
petermetz
force-pushed
the
adrianbatuto/issue3457
branch
from
0b74687 to
ddcc195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Changes
Fixes #3457
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.