Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use toolchain to set Go version #684

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

mattjohnsonpint
Copy link
Member

Description

This is a follow up to #660. Going forward, all projects in the repo will behave the same way:

  • Minimum Go version will be set with the go declaration in go.mod / go.work files.
    • High/Critical CVEs in Go will raise this version. ie., it is currently 1.23.1, even though the code will technically compile against 1.23.0.
  • Recommended Go version will be set with the toolchain declaration in go.mod / go.work files.

Currently, this means all projects should have:

go 1.23.1

toolchain go1.23.4

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner January 7, 2025 21:43
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) January 7, 2025 21:50
@mattjohnsonpint mattjohnsonpint merged commit 3b279fc into main Jan 7, 2025
66 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/go-tooolchain branch January 7, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants