Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetchActiveActions without param page #250

Closed
wants to merge 9 commits into from

Conversation

EnchStudio
Copy link

No description provided.

@EnchStudio
Copy link
Author

@FC5570

Copy link
Member

@FC5570 FC5570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could please describe why this change was made?

Copy link
Member

@FC5570 FC5570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove the dist folder
  • Please remove the "Fixed version" heading from the Readme file
  • Please remove the "author" field from package.json, and revert the version bump.

@EnchStudio
Copy link
Author

EnchStudio commented Jul 20, 2024

hypixel have so many auctions that they can't be displayed in one page, so you should pass a page param to get auctions for special page.
sry but i dont have enough time for this project, so i just forked one.
so you can do these change easily, and close my pr thx

@EnchStudio
Copy link
Author

  • Please remove the dist folder请删除 dist 文件夹
  • Please remove the "Fixed version" heading from the Readme file请从自述文件中删除“固定版本”标题
  • Please remove the "author" field from package.json, and revert the version bump.请从 package.json 中删除“author”字段,并恢复版本更新。

ok this is my problem, i just modified some file and release my fork version, but i forgot i have pr my branch

@FC5570 FC5570 closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants