Nrami006 threads #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved threadGraveyard declaration/definition and condition::wait() definition up a bit so that thread_cancel() could be called where pthread_exit() used to be called.
Implemented pseudoProcess class that derives from Thread.
Constructor takes in the name, priority, and vector of strings.
Action creates an argv from the vector of strings and then forks and execs argv (the fork is so that the main thread does not die).
This seems to be working so far. Just need to implement it with the shell code now. Maybe move pseudoProcess into the thread.h file.
Note: If you want them to be able to call join(), you need to derive publically from Thread.
i.e: class pseudoProcess : public Thread {
...
};
Moved implementation of pseudoProcess into the shell team's code and defined its action() to be their 'thread_run()' function. I also replaced their calls to std::thread(...) with pseudoProcess(...). It works with shellThread.h file which is just a modified workingThread.h (I just moved the pseudoProcess out of there and into the shellMain.cc file). Notes: If the shell code is going to be a .h file, maybe we could move pseudoProcess back into our thread.h file by including the shell.h file into our thread.h file. That way we could have access to their functions without having to copy it into our file.
Moved pseudoProcess into shellMain.cc.
Added parent Thread* and a threaD_id member variable that stores the threads own id.
changed nothing.
Commented out debugging classes and comments and asserts
Cleaned up. took out debugging classes/ comments/ asserts. Tested with shell team code and it should work.
Modified shell team code to include a shellThread class as well as use it. should work with threads.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.