-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 2fa #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes mfaEnabled from user field interceptor - Removes mfaEnabled from PatchUserDto - Removes secrets from the frontend user model
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
julianochoi
commented
Nov 26, 2023
backend/src/interceptors/remove-users-fields/remove-users-fields.interceptor.ts
Show resolved
Hide resolved
- chore: cleanup in user dto
- Fixes redirect not pushing to auth/2fa
vcwild
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iaurg
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Splits auth-only updates from user update service - Removes mfaEnabled from user field interceptor - Removes mfaEnabled from PatchUserDto - Removes secrets from the frontend user model * fix: Removes duplicate Toaster - chore: cleanup in user dto * Fixes CORS on 2fa code submission - Fixes redirect not pushing to auth/2fa
vcwild
added a commit
that referenced
this pull request
Dec 5, 2023
* feat: activate loggers on game * feat: component to invite user to a game * feat: game invite prototype * ref: inviteError event name change * Feature: Implement chat DMs between friends (#128) * feat: implement chat DMs between friends - Remove finished todos - Add some alt text to components - Private chats don't show in the main chat lobby anymore - Only private chats created by the user are temporarily displayed in the chat lobby - If a user resets its chat component, all of the DM chats are removed - All chat DMs are database persisted * lint: remove unused imports * fix: filter private chat to no appear on list chats * style: resize name and hide users popover on dm * style: fixed chat width * style: add cursor pointer into dm icon --------- Co-authored-by: Italo A <italoaurelior@gmail.com> * feat/127-add-alt (#132) * feat: add action hover tip on each button * fix: use a single alt attribute --------- Co-authored-by: Victor Wildner <vwildner@redhat.com> * Fix/125-chat-reload (#133) * style: cards justify * fix: chat reloading when access history page * feat/game-actions (#134) * feat: better game actions and titles * feat: show player name on play screen * feat: unmute user automatically after 5s (#136) * feat/owner-chat-actions (#135) * feat: allow owner update and remove password from chat * fix: wrong html tree * feat: update chat listing on render list * feat: on chat open goes to the bottom * refactor: remove console log * feat: update lock icon * fix: avoid read undefined * fix: missing provider and duplicated toaster --------- Co-authored-by: Victor Wildner <vwildner@redhat.com> * Feat/profile popover (#138) * refactor: remove not user isFriend property * feat: add buttons and remove bio description --------- Co-authored-by: Victor Wildner <vwildner@redhat.com> * Feat/descriptive top buttons (#139) * feat: add missing back home button * feat: more descriptive menu actions * Fixes 2fa (#130) * Splits auth-only updates from user update service - Removes mfaEnabled from user field interceptor - Removes mfaEnabled from PatchUserDto - Removes secrets from the frontend user model * fix: Removes duplicate Toaster - chore: cleanup in user dto * Fixes CORS on 2fa code submission - Fixes redirect not pushing to auth/2fa * Feat/front block user (#144) * feat: add block button * feat: replicate button pattern * fix: avatar wrong initial letter * feat: implement block user (#148) * Fix: Cleaning abandoned lobby rooms (#142) * feat: activate loggers on game * feat: component to invite user to a game * feat: make game a global context * refactor: game invite to game * style: lint file * feat: implement invite player to game * fix: returning game copy instead game reference * ref: cleaning invite lobby in disconnect * fix:game invite * feat: modal to handle invite actions * refactor: remove not used imports * feat: add guestRejected emit socket * refactor: update match history create to update with login * refactor: remove not used player user id * feat: add invite rejected actions and alerts * fix: inviting offline player * ref: class attributes * feat: stopGame event handler * fix: event call stopGame on gameFinished handler * feat: modal in game not show * fix: breaking line names * refactor: remove not used template * style: responsive elements * fix: client not leaving socket room * fix: abandoned game still running * feat: player that abandone game looses * ref: removing useless code * ref: removing useless code --------- Co-authored-by: Guilherme Martinelli <guilhermefmartinelli@gmail.com> Co-authored-by: Victor Wildner <vwildner@redhat.com> Co-authored-by: Juliano Choi <julianochoi@gmail.com> Co-authored-by: Guilherme Ferreira Martinelli <82342210+GuiMartinelli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes made in this pull request.]
Related Issue
[Closes/Fixes/Resolves #[issue number]: Describe the related issue that this PR addresses.]
Closes #129