feat: ExpandDateTime convenience

[sfc-gh-twhite]

Closes #14

Combined the functionality of these and added a test for it.

I didn't re-use the existing code in the implementation, so it may be worth a revisit to see if there is a preferred method. :)

Here's a quick snippet I wrote for testing!

from ibis.interactive import *
import ibisml as ml


t = con.sql("select get_current_timestamp() AS datetime")
step = ml.ExpandDateTime("datetime")
transform = step.fit(t, ml.core.Metadata())
res = transform.transform(t)
res

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓
┃ datetime                      ┃ datetime_dow ┃ datetime_month ┃ datetime_year ┃ datetime_hour ┃ datetime_minute ┃ datetime_second ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩
│ timestamp('UTC', 6)           │ int16        │ int64          │ int32         │ int32         │ int32           │ int32           │
├───────────────────────────────┼──────────────┼────────────────┼───────────────┼───────────────┼─────────────────┼─────────────────┤
│ 2023-12-12 19:40:52.459+00:00 │            1 │             11 │          2023 │            19 │              40 │              52 │
└───────────────────────────────┴──────────────┴────────────────┴───────────────┴───────────────┴─────────────────┴─────────────────┘

[gforsyth]

Thanks for putting this in @sfc-gh-twhite !

Overall I think this is good implementation, and I am 100% ok with duplicating some code.

My main question throughout is whether it would be more convenient on the user side to not have to specify the date and time components separately? Given that this is a convenience method to combine the functionality of two other existing methods, I would be inclined to smash it all together so you don't have to pass in two separate lists of components to use it.

What do you think?

[gforsyth]

Is there value in separating these into date and time components? What if it were datetime_components throughout?

[sfc-gh-twhite]

I agree! It would be worthwhile to combine the two rather than separating them. I can give it another try!

I adjusted the test to use ml.timestamp() rather than the column name.

[gforsyth]

Hey @sfc-gh-twhite ! Hope you had a nice break over the holidays. Did you want to take another crack at combining the date and time components into a single set?

[sfc-gh-twhite]

Hey @gforsyth, I do plan to get back to this! I've been spending more time with the core Ibis project, but I am jumping back to IbisML and can hopefully get something together soon.

[jcrist]

Closing as superseded by #20.