Plumb through y in fit and fit_transform
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all steps would only rely on `X` during fitting, so we completely ignored `y` if it was passed in. We now have at least one desired `Step` that relies on `y` during the fitting process, which means we need to start properly handling `y` in `fit`/`fit_transform`. This PR handles: - normalizing `X` and `y` to a single `Table` from a variety of possible inputs - Plumbing through `X` and `y` metadata through `fit` and `fit_transform`. Still needs a bunch of tests, but I believe this works already in general.
jcrist
changed the title
y in fit and fit_transformy in fit and fit_transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all steps would only rely on
Xduring fitting, so we completely ignoredyif it was passed in. We now have at least one desiredStepthat relies onyduring the fitting process, which means we need to start properly handlingyinfit/fit_transform.This PR handles:
Xandyto a singleTablefrom a variety of possible inputsXandymetadata throughfitandfit_transform.Still needs a bunch of tests, but I believe this works already in general.