chore(refactor): handle 0-length args in highest_precedence_shape() #9333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
requested changes
Jun 7, 2024
| @@ -16,6 +17,9 @@ | |||
|
|
|||
| @public | |||
| def highest_precedence_shape(nodes): | |||
| nodes = tuple(nodes) | |||
| if len(nodes) == 0: | |||
There was a problem hiding this comment.
Suggested change
| if len(nodes) == 0: | |
| if not nodes: |
|
What's the rationale for the general case of no arguments being This seems like it should raise an exception in the general case and we should specialize the semantics in cases where it makes sense. |
|
hmm I think you are right, we want to be explicit and have users be resonsible for dealing with this edge case. Imagine there is some case we haven't found that causes a 0-length arg. With this change, that would now give scalar, even if that might be silently wrong. I think we would rather have that undiscovered situation do a hard error, then get a bug report about it. slightly related as I explored this more: #9334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving towards #8666