XEP-0084: User Avatar implementation #107
Conversation
ramabit
force-pushed
the
ramabit.avatar
branch
from
a35dea3 to
85a82eb
Compare
| return getNode(METADATA_NAMESPACE); | ||
| } | ||
|
|
||
| private LeafNode getNode(String nodeName) |
There was a problem hiding this comment.
That is why it's a good idea to have PubSubManager.getOrCreateNode(String): You are duplicating code that you already wrote for Geo Location here.
| */ | ||
| public class MetadataInfo { | ||
|
|
||
| private String id; |
| */ | ||
| public class MetadataPointer { | ||
|
|
||
| private String namespace; |
| public static final String ELEMENT = "data"; | ||
| public static final String NAMESPACE = UserAvatarManager.DATA_NAMESPACE; | ||
|
|
||
| private byte[] data; |
| * | ||
| * @return the data | ||
| */ | ||
| public byte[] getData() { |
There was a problem hiding this comment.
return a copy of the data to keep DataExtension immutable.
| public static final String ELEMENT = "metadata"; | ||
| public static final String NAMESPACE = UserAvatarManager.METADATA_NAMESPACE; | ||
|
|
||
| private List<MetadataInfo> infos; |
|
@Flowdalic please check the last fixes :) |
| public class MetadataInfo { | ||
|
|
||
| private final String id; | ||
| private final String url; |
| this.url = url; | ||
| this.bytes = bytes; | ||
| this.type = type; | ||
| this.height = pixelsHeight; |
There was a problem hiding this comment.
height and width are xs:unsingedByte, thus the constructor should ensure that it's value is within the range of [1,254] and otherwise throw an IllegalArgumentException.
| */ | ||
| public MetadataPointer(String namespace, HashMap<String, Object> fields) { | ||
| this.namespace = namespace; | ||
| this.fields = fields; |
There was a problem hiding this comment.
Should be wrap with Collections.umodifyableList()
| */ | ||
| public boolean isSupportedByServer() | ||
| throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException { | ||
| return findNodeItem(DATA_NAMESPACE) && findNodeItem(METADATA_NAMESPACE); |
There was a problem hiding this comment.
I don't think that this is how you determine if xep84 is supported by the server. You likely just need to check if PEP is supported.
| * | ||
| * @return the data as String | ||
| */ | ||
| public String getDataAsString() { |
There was a problem hiding this comment.
This should be called getDataBase64Encoded(). To make it clear that the string representation of the data is base64 encoded.
| outerloop: while (true) { | ||
| int eventType = parser.next(); | ||
|
|
||
| if (eventType == XmlPullParser.START_TAG) { |
There was a problem hiding this comment.
This should use switch/case on the eventType int.
|
|
||
| if (eventType == XmlPullParser.START_TAG) { | ||
|
|
||
| if (parser.getName().equals("info")) { |
There was a problem hiding this comment.
This should use switch/case on the getName() string.
|
I'll close this in favor of #332 |
Documentation: http://xmpp.org/extensions/xep-0084.html