Add dialog to choose between Auto Combat and Quick Combat

[zenseii]

This will let more users notice the Quick Combat feature and it will give touch devices access to Quick Combat.

This PR also adds basic shine effect to the generated buttons' edges.

Related to #9095 and #9100

Fix #9094

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[zenseii]

@oleg-derevenetz, I'm done pushing changes to this branch now. If you have the chance to look over the changes from resolve/instant to quick then that would be greatly appreciated.

[oleg-derevenetz]

I'm done pushing changes to this branch now. If you have the chance to look over the changes from resolve/instant to quick then that would be greatly appreciated.

Thank you! I'll make an effort to take a look during tomorrow.

[zenseii]

@LeHerosInconnu, I've addressed your text suggestions. I shortened this text because action was redundant in this context and undone already implies that something has been done, and the word validate doesn't work in this context.

As for this description I changed the part about while you observe because it sounds like the game is forcing you to sit down and watch. activating was changed with performing since that is the correct expression, alternatively we could just say right or left clicking.

[LeHerosInconnu]

Hello @zenseii,

@LeHerosInconnu, I've addressed your text suggestions. I shortened this text because action was redundant in this context and undone already implies that something has been done, and the word validate doesn't work in this context.

The words "resolved" and "ended" mean the same thing, and the "and ended" part makes the sentence a bit cumbersome.

What about:
"The combat is resolved from the current state to the end."

As for this description I changed the part about while you observe because it sounds like the game is forcing you to sit down and watch. activating was changed with performing since that is the correct expression, alternatively we could just say right or left clicking.

The "at the currently set combat speed" part of the sentence will raise a question in the user's mind: "What does that mean?"; whereas the text should be descriptive and clear.

As for this description I changed the part about while you observe because it sounds like the game is forcing you to sit down and watch.

This indicates that the user will be watching the combat (it's simply a description of what happens in this mode), and that he will be able to observe the AI's actions, which may be beneficial to his understanding of how the AI works.

alternatively we could just say right or left clicking.

Since "by pressing" is used for keys and is not really suitable for clicks (mouse or other, we press a button not a click), there is need to use a more appropriate term for clicks and in the same style as "by pressing", "by performing" is fine.

Why replace the word "time" with "moment"?

What about:
"The computer continues the combat for you, while you watch the progression of the combat.

This can be interrupted at any time by pressing the Auto Combat hotkey or the default Cancel key, or by performing a left or right click anywhere on the game screen."

[Branikolog]

"The combat is resolved from the current state to the end."

Looks nice.
However "The combat ends instantly from the current state." looked good for me too.

The "at the currently set combat speed" part of the sentence will raise a question in the user's mind: "What does that mean?"; whereas the text should be descriptive and clear.

I agreed. Mentioning speed is useless in the description.
Mentioning "the progression of the combat" also feels redundant, since we're mentioning in the following description, that the battle could be interrupted at any moment...

What about more short and simple? "The computer continues the combat for you in auto mode/automatically"?
I'm even OK with "The computer continues the combat for you."

[zenseii]

@LeHerosInconnu and @Branikolog.

Let's make it simple and just say "The combat is resolved from the current state." The simpler we can make it, the better.

I also agree with "The computer continues the combat for you." Continue does imply some similarity to how you were doing the battle up to that point and therefore implies that you can observe it, if you wish. Or you can go and make a sandwich in the meantime. The "while you watch" part sounds like the game is telling you that you have to watch. As @Branikolog points out, it's implied that you can watch it.

As for changing time with moment, this isn't only just a matter of taste. Generally words from Latin/French, like moment, are considered more formal than their more casual Germanic counterparts, like time. Another example is the difference between "in a fight" and "in combat" which technically mean the same, but fight being the Germanic word means it is more casual.

Therefore, considering the language used in the game in general, like in the videos and the dialogs, moment fits better than time in my opinion.

[LeHerosInconnu]

@Branikolog and @zenseii,

So, I am fine to go with:

"The combat is resolved from the current state.

This cannot be undone."

and:

"The computer continues the combat for you.

This can be interrupted at any moment by pressing the Auto Combat hotkey or the default Cancel key, or by performing a left or right click anywhere on the game screen."

[ihhub]

@zenseii , many thanks for this useful feature!