Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic interface option #9413

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

felix642
Copy link
Contributor

@felix642 felix642 commented Jan 5, 2025

Added dynamic interface (good / evil) based on the player's race.
Relates to: #1329 (Despite the title, this issue also references the ability to hide the hero's path which was not added in this PR so we can't close it yet).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/system/settings.cpp Outdated Show resolved Hide resolved
@oleg-derevenetz oleg-derevenetz added improvement New feature, request or improvement ui UI/GUI related stuff labels Jan 5, 2025
@oleg-derevenetz oleg-derevenetz added this to the 1.1.6 milestone Jan 5, 2025
@ihhub ihhub requested review from ihhub and Districh-ru January 6, 2025 11:38
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @felix642, I missed Dynamic interface option after the original game. Thanks for making this PR!
I left several comments to make it a bit better. Could you please check them when you have time?

src/fheroes2/dialog/dialog_interface_settings.cpp Outdated Show resolved Hide resolved
src/fheroes2/dialog/dialog_interface_settings.cpp Outdated Show resolved Hide resolved
src/fheroes2/game/game_startgame.cpp Outdated Show resolved Hide resolved
src/fheroes2/system/settings.cpp Show resolved Hide resolved
@Districh-ru Districh-ru self-requested a review January 20, 2025 18:49
@Districh-ru Districh-ru self-requested a review January 25, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants