-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add Chisel Blink, use Action setup-scala #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation for using two different Actions to setup Java/Scala? It seems that both of them support all three platforms. Should there be a limitation in actions/setup-java
that requires the other one, I'd suggest using it for all platforms and adding a comment explaining why that is required.
At the same time, the toolchain can be installed locally by using the same script as in CI. The only requirement is Python. What would be the minimal requirements for someone to try this example locally? That is, what's the alternative to setup-java|setup-scala? Note that I don't expect it to be explained here, but to add some reference to Scala/Chisel docs in an upcoming PR.
I changed the CI to use Do you want me to squash my commits?
I will keep that in mind. Essentially you just need a recent version of Java (like OpenJDK 11) and the sbt build tool which will in turn download the correct Scala compiler version etc. once you run the build. |
What was the reason to choose that instead of the other?
No need, GitHub allows to do it while merging. |
On Windows and Ubuntu |
ci: install Scala on MacOS using Action olafurpg/setup-scala (im-tomu/fomu-workshop#384)
This solves one half of issue #383