-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen, remote control and overview navigation #711
Conversation
Add autoplay pause on blackout and resume when removeBlackout Add events to pause/resume autoplay
|
On firefox, after blackout, slides where partially rendered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @giflw for this new year's present! I have some minor comments and questions only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Thanks for more work. The full help looks great, except does not conform to style / user experience. I will help you get it right.
But at this point it would be better to split this work into multiple small PRs. This is necessary to maintain a clean commit history where one thing is one commit. (You had done that originally, but then the fixes spoil it.) Also, some of your work is ready to be merged while other parts need changes still. This way we can merge the good parts already.
Could you create separate branch+PR for each:
- fullscreen.js (this is ready to go I think)
- autoplay.js (likewise)
- blackout.js (please remove the impress:help:add for now)
- help.js (Functionally you're doing the right thing, but this will need several changes.)
- navigation.js (Needs to be done differently, we can discuss in new PR.)
Sorry for the extra work, but on the positive side, this will get most of your code merged asap rather than always doing a little bit more.
No problem. I'll do that as soon as I can. |
@henrikingo Added PR #712 for fullscreen |
@henrikingo Added PR #713 for pause/resume events on autoplay |
@henrikingo Changes on blackout needs autoplay to be merged, as it is used to pause/resume autoplay when enter/exit blackout |
@henrikingo Added PR #714 for full help screen on help plugin |
@henrikingo Added PR #716 for blackout support for |
@henrikingo Added PR #717 for navigation ( |
Add impress.js updated blackout and fullscreen plugins
This update add support for remote control presentation buttons:
Next and previous slides using PageUp/PageDown are already supported
This PR is being splitted into: