feat: add ioxQuery limits #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for viewing and modifying the new IOx Query limits.§
|
Is it possible to add a before and after screenshot in the description? Something like this #6657 |
| @@ -339,6 +339,28 @@ export const OrgOverlay: FC = () => { | |||
| </Grid.Column> | |||
| </Grid.Row> | |||
| )} | |||
| {limits?.ioxQuery && ( | |||
There was a problem hiding this comment.
Seems like ioxQuery is defined under the type OrgLimits, but limits is a type of OperatorOrgLimits
There was a problem hiding this comment.
I think this is now resolved after influxdata/openapi#649
@mhilton and I discussed this: Given the current implementation for mocking these limits, the addition of this limit on the operator page will not reflect meaningful data in local dev. I will add more details in the 🧵 , but staging is the better place to revalidate this. |
wdoconnell
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for viewing and modifying the new IOx Query limits.
Closes #
Checklist
Authors and Reviewer(s), please verify the following: