Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Dockerfile and compose.yaml $PORT really configurable #1134

Merged
merged 8 commits into from
Jan 31, 2025
Merged

Make Dockerfile and compose.yaml $PORT really configurable #1134

merged 8 commits into from
Jan 31, 2025

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented Jan 30, 2025 •
edited
Loading

There already existed an embryo of a generic solution but it was falling short because of the two following issues which this PR fixes:

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.15%. Comparing base (26d43ee) to head (17f8f78).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   73.25%   73.15%   -0.11%     
==========================================
  Files         773      773              
  Lines       11938    11938              
  Branches     1456     1456              
==========================================
- Hits         8745     8733      -12     
- Misses       2702     2709       +7     
- Partials      491      496       +5
Flag Coverage Δ
client 53.26% <ø> (-0.05%) ⬇️
server 61.67% <ø> (-0.10%) ⬇️
test 77.80% <ø> (-0.14%) ⬇️
test-app 58.20% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again changed the title Add deploy test to check that $PORT can be configured Add GHA jobs to check that $PORT can be configured Jan 30, 2025
@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review January 31, 2025 09:13
@make-github-pseudonymous-again make-github-pseudonymous-again changed the title Add GHA jobs to check that $PORT can be configured Make Dockerfile and compose.yaml $PORT really configurable Jan 31, 2025
Merged via the queue into main with commit 6e07282 Jan 31, 2025
38 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the cd-polish-port-configuration-1 branch January 31, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Healthcheck endpoint port is hardcoded in Dockerfile Only customize published port in Docker Compose
1 participant
@make-github-pseudonymous-again